Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Update pirate & zombie domains for tests #1705

Merged
merged 1 commit into from
Mar 12, 2023
Merged

[r2r] Update pirate & zombie domains for tests #1705

merged 1 commit into from
Mar 12, 2023

Conversation

smk762
Copy link

@smk762 smk762 commented Mar 9, 2023

Test are passing locally except for test qrc20::qrc20_tests::test_wait_for_confirmations_excepted ... FAILED which is unrelated to these changes.

shamardy
shamardy approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

laruh
laruh approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ca333 ca333 merged commit 944ac4e into dev Mar 12, 2023
@shamardy shamardy deleted the update_pirate_zombie_domain branch March 13, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laruh laruh laruh approved these changes

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@shamardy shamardy shamardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smk762 @shamardy @onur-ozkan @laruh @ca333