Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nft request for wasm target #1817

Merged
merged 6 commits into from
May 11, 2023
Merged

Fix nft request for wasm target #1817

merged 6 commits into from
May 11, 2023

Conversation

laruh
Copy link
Member

@laruh laruh commented May 10, 2023

This pr fixes error sending request in wasm

{"mmrpc":"2.0","error":"Transport: nft:252] wasm_http:160] Internal(\"JsValue(TypeError: Failed to construct 'Request': Request with GET/HEAD method cannot have body.\")","error_path":"nft","error_trace":"nft:252]","error_type":"Transport","error_data":"nft:252] wasm_http:160] Internal(\"JsValue(TypeError: Failed to construct 'Request': Request with GET/HEAD method cannot have body.\")","id":null}

@onur-ozkan
Copy link
Member

It's sad we didn't catch this in tests. Can you write some integration tests for moralis?

@laruh laruh added in progress Changes will be made from the author and removed under review labels May 11, 2023
onur-ozkan
onur-ozkan previously approved these changes May 11, 2023
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two non-blocker comments

mm2src/coins/nft.rs Show resolved Hide resolved
mm2src/coins/nft/nft_tests.rs Outdated Show resolved Hide resolved
@laruh laruh added under review 1.0.4-beta and removed in progress Changes will be made from the author labels May 11, 2023
@shamardy
Copy link
Collaborator

@laruh can you please resolve the merge conflict related to the changelog?

@laruh
Copy link
Member Author

laruh commented May 11, 2023

@laruh can you please resolve the merge conflict related to the changelog?

@shamardy Thanks, done

@shamardy shamardy merged commit fbe9f16 into dev May 11, 2023
@shamardy shamardy deleted the fix-wasm-nft branch May 11, 2023 16:02
@shamardy shamardy mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants