Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nft): db implementation (wasm target) #1877
feat(nft): db implementation (wasm target) #1877
Changes from 131 commits
7a62de0
350f1d5
08ba26c
7d0edf1
5df609e
b0d965f
6d12a42
6d84038
9ef02b7
67133a2
f935e5a
f249593
2d66f8f
9225e99
9f977f3
de5cff6
65c702b
52b3c32
6d34df5
9bf6453
0a19dba
9e2b935
8349de1
d2e0653
3e5cd51
7ba5c30
64fa485
b37f9a8
844c9e5
d9c36a5
62ebf79
9811680
d652772
190aba3
8a64b4a
330af7a
c31baa0
590cb76
8cc5413
9bae1af
1b10b14
12d0b60
429161a
d5efb28
e68155c
106e18d
3d5dd43
6fc16cf
2e70203
c08d996
342491c
16f028b
158542c
cb29933
7941fe3
3323643
9947d97
4d2e5e2
94b9fe8
b67e5e1
ef7bf54
54220c3
e3d19f1
be984ef
76e2505
38814e4
f919a37
217c199
bbe4be5
9c1e2f4
a959df2
f05baaf
480f648
8291f20
a45fd13
4f16c82
72a85c1
fa4c34e
f7ff673
e80c4b0
02b9f5f
464dbdf
8be6ab0
8e3be13
b3f7a1e
84b94bc
016482d
400e445
f4fcc9b
c49fd35
2697d0a
3f09071
70d1de4
cd64d40
590de5f
1143057
c33a014
5ca2933
59c0db5
f3e0776
b5bd19b
e18f932
23dd751
5df10a8
c7c424f
fd7fc03
d2c1e5e
ec9ed68
c77d236
5992d28
300091e
5e86a83
740a284
9f6e0c6
f2be86a
92f28aa
cc6ddd6
7d4c7fc
a17e346
2ce92e4
9b4b85e
0d8bebe
e869b0c
e8e13de
a0b5e4a
7a821a2
167bde2
1746503
755ebc6
8471fbc
cf6ff1a
478b178
345cf5f
221c8e4
5b05033
3defed0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some malicious testings for
check_moralis_ipfs_bafy
and all other functions that does input validations.e.g. make the input as
example.com/bafy?1=ipfs.moralis.io&e=https://
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added tests:
test_invalid_moralis_ipfs_link
,test_check_for_spam
note that function
check_moralis_ipfs_bafy
dont redact url or propagate the error iftoken_uri
is invalid.This param we get from moralis and if there is unvalid url may be its moralis mistake, or NFT token had this mistake in nft metadata, we should show the uri as it is. We still can try to build
UriMeta
structure frommetadata
field.