-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(posv): fix missing n_time in posv transactions #1925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and working to create successful withdrawals
smk762@pig:~/mm2_777$ ./connect_RDD.sh
{"result":"success","address":"RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg","balance":"51.76764736","unspendable_balance":"0","coin":"RDD","required_confirmations":5,"requires_notarization":false,"mature_confirmations":30}
smk762@pig:~/mm2_777$ ./withdraw2.sh RDD RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg 1
{"mmrpc":"2.0","result":{"tx_hex":"0200000001532551126b30dda21ad826c440413e1db8036c3bd87bf80aa1fce91b51457de5000000006a47304402207161eee616d2a9ab57a96dc3ad3168d80631e125ca776d7b91d51a9be9852b8d02205337e63bd849e70b20e462f9e4f66ea170dc091273539b1ac95d030027952603012103d8064eece4fa5c0f8dc0267f68cee9bdd527f9e88f3594a323428718c391ecc2ffffffff0200e1f505000000001976a914d346067e3c3c3964c395fee208594790e29ede5d88aca0c1972e010000001976a914d346067e3c3c3964c395fee208594790e29ede5d88acb84dc764b84dc764","tx_hash":"869f4770950becaaa00c92c8f0cfe2a98b2ffca166fb15eafb789a3399c8aef6","from":["RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg"],"to":["RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg"],"total_amount":"51.76764736","spent_by_me":"51.76764736","received_by_me":"51.76664736","my_balance_change":"-0.001","block_height":0,"timestamp":1690783160,"fee_details":{"type":"Utxo","coin":"RDD","amount":"0.001"},"coin":"RDD","internal_id":"","transaction_type":"StandardTransfer","memo":null},"id":0}smk762@pig:~/mm2_777$
smk762@pig:~/mm2_777$ ./sendrawtransaction.sh RDD 0200000001532551126b30dda21ad826c440413e1db8036c3bd87bf80aa1fce91b51457de5000000006a47304402207161eee616d2a9ab57a96dc3ad3168d80631e125ca776d7b91d51a9be9852b8d02205337e63bd849e70b20e462f9e4f66ea170dc091273539b1ac95d030027952603012103d8064eece4fa5c0f8dc0267f68cee9bdd527f9e88f3594a323428718c391ecc2ffffffff0200e1f505000000001976a914d346067e3c3c3964c395fee208594790e29ede5d88aca0c1972e010000001976a914d346067e3c3c3964c395fee208594790e29ede5d88acb84dc764b84dc764
{"tx_hash":"869f4770950becaaa00c92c8f0cfe2a98b2ffca166fb15eafb789a3399c8aef6"}
https://live.reddcoin.com/tx/869f4770950becaaa00c92c8f0cfe2a98b2ffca166fb15eafb789a3399c8aef6
@reddink can you please rebase your branch to dev since it was based on main? |
@shamardy |
this is a fix for the Reddcoin withdrawal issue.
electrum was reporting that it could not parse transaction
On investigating, the issue was a missing n_time field in the generated transaction
The fix now correctly considers when n_time is required, and the rawtransaction can be broadcast