Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kmd): use kmd rewards for fees if change + interest is below dust #1944

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix(kmd): use kmd rewards for fees if change + interest is below dust #1944

merged 2 commits into from
Aug 24, 2023

Conversation

shamardy
Copy link
Collaborator

No description provided.

@shamardy shamardy changed the title fix(kmd): use kmd rewards for fees if unused change and interest is below dust fix(kmd): use kmd rewards for fees if unused change + interest is below dust Aug 23, 2023
@shamardy shamardy changed the title fix(kmd): use kmd rewards for fees if unused change + interest is below dust fix(kmd): use kmd rewards for fees if change + interest is below dust Aug 23, 2023
@shamardy shamardy added the in progress Changes will be made from the author label Aug 23, 2023
@shamardy shamardy marked this pull request as ready for review August 23, 2023 10:05
@shamardy shamardy added under review P1 and removed in progress Changes will be made from the author labels Aug 23, 2023
@cipig
Copy link
Member

cipig commented Aug 23, 2023 •
edited
Loading

thanks for the quick fix, it works fine
swapped entire KMD balance for LTC
there was only one KMD UTXO and it had a reward of < 100 sats
this is KMD takerpayment: https://kmdexplorer.io/tx/21efec9e166970f47cf73a1ecb2adaa401251e0b856fb580a06b1de4e9031b49

artemii235
artemii235 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shamardy shamardy merged commit 410eda2 into dev Aug 24, 2023
24 of 34 checks passed
@shamardy shamardy deleted the fix-dust-kmd-reward branch August 24, 2023 08:55
@shamardy shamardy mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@artemii235 artemii235 artemii235 approved these changes

@dimxy dimxy Awaiting requested review from dimxy

Assignees
No one assigned
Labels
P1 under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamardy @cipig @artemii235