-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(zhtlc): Use alternative grpc service name for pirate lightwalletd #1963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
ARRR coin activation was completed as expected.
{"mmrpc":"2.0","result":{"status":"InProgress","details":{"BuildingWalletDb":{"first_sync_block":{"requested":2558042,"is_pre_sapling":false,"actual":2558042},"current_scanned_block":2558042,"latest_block":2559482}}},"id":null}
{"mmrpc":"2.0","result":{"status":"Ok","details":{"ticker":"ARRR","current_block":2559482,"wallet_balance":{"wallet_type":"Iguana","address":"zs1gn3mxk493yyvyu8ffsgj6kt3luajdezwr6t7lzzfjf34u4nzztze3r44wplm0ry95tp4uang9yg","balance":{"spendable":"0","unspendable":"0"}},"first_sync_block":{"requested":2558042,"is_pre_sapling":false,"actual":2558042}}},"id":null}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Note for the future: if we would like to support original Zcash/lightwalletd, we will need to add their proto definitions and use them, depending on the ticker of the coin (or make it configurable somehow).
ref: https://github.com/PirateNetwork/lightwalletd/blob/master/walletrpc/service.proto#L7
Infrastructure for ARRR lightwallet servers uses a fork of lightwalletd which has renamed the grpc service name from
cash.z.wallet.sdk.rpc;
topirate.wallet.sdk.rpc;
To use these, the changes in this PR are needed. Once merged, existing lightwalletd servers from ZOMBIE will need to run on the pirate fork of lightwalletd.
Until these changes are merged, a single lightwalletd server configured with
cash.z.wallet.sdk.rpc;
is available. This server will remain online over the period between next api release and related app releases.To test:
and the electrum servers in https://github.com/KomodoPlatform/coins/pull/811/files
and the electrum servers in https://github.com/KomodoPlatform/coins/pull/811/files
"error":"All the current light clients are unavailable."