Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(UTXO): transaction deserialization #1993

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

refactor(UTXO): transaction deserialization #1993

wants to merge 1 commit into from

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Oct 13, 2023 •
edited
Loading

WIP

@onur-ozkan
refactor UTXO transaction deserialization
4e4ecdc 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan added micro-opt Optimization at very minimal level under review in progress Changes will be made from the author and removed under review labels Oct 13, 2023
@onur-ozkan onur-ozkan marked this pull request as draft October 13, 2023 09:13
dimxy
dimxy reviewed Jun 28, 2024
View reviewed changes
mm2src/mm2_bitcoin/chain/src/transaction.rs
let mut buffer = vec![];
reader.read_to_end(&mut buffer)?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why you do not want to use read_to_end().
I took a look at its code, apparently it uses a too small buffer of 32 byte to read, is this the reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimxy dimxy dimxy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
in progress Changes will be made from the author micro-opt Optimization at very minimal level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onur-ozkan @dimxy