Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2pk-tests): fix p2pk tests post merge #2119

Merged
merged 4 commits into from
May 17, 2024
Merged

fix(p2pk-tests): fix p2pk tests post merge #2119

merged 4 commits into from
May 17, 2024

Conversation

shamardy
Copy link
Collaborator

No description provided.

@shamardy shamardy changed the title fix(p2pk-tests): Fix p2pk tests post merge fix(p2pk-tests): fix p2pk tests post merge May 15, 2024
@shamardy shamardy requested a review from mariocynicys May 15, 2024 21:54
mariocynicys
mariocynicys reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some Qs.

Also, was/is cargo fmt broken? why some parts in some files were misformatted?

mm2src/mm2_main/tests/mm2_tests/mm2_tests_inner.rs Show resolved Hide resolved
mm2src/coins/utxo/utxo_tests.rs Show resolved Hide resolved
mm2src/coins/utxo/utxo_common.rs Outdated Show resolved Hide resolved
mariocynicys
mariocynicys approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamardy shamardy merged commit 2bbb75c into dev May 17, 2024
21 of 25 checks passed
@shamardy shamardy deleted the fix-p2pk-tests-post-merge branch May 17, 2024 11:17
dimxy added a commit that referenced this pull request May 22, 2024
@dimxy
Merge branch 'dev' into burn-dex-fee-for-non-kmd
0f34d2e 
* dev:
  feat(ETH): eip1559 gas fee estimator and rpcs (#2051)
  fix(p2pk-tests): fix p2pk tests post merge (#2119)
  fix(p2pk): show and spend P2PK balance (#2053)
  fix(swap): use tmp file for swap and order files (#2118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamardy @mariocynicys