Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): tendermint withdraws on hd accounts #2130

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

onur-ozkan
Copy link
Member

Fixes a regression (check mm2_tests::tendermint_tests::test_tendermint_withdraw_hd test) which started with pubkey-only activation implementation.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan added bug Something isn't working P0 under review labels May 31, 2024
@onur-ozkan onur-ozkan requested a review from shamardy May 31, 2024 06:43
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this issue and fixing it!

@shamardy shamardy merged commit 74bb53c into dev May 31, 2024
23 of 28 checks passed
@shamardy shamardy deleted the fix-hd-account-withdraw branch May 31, 2024 11:53
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request Jun 17, 2024
* dev:
  fix(indexeddb): window usage in worker env (KomodoPlatform#2131)
  feat(tx-history): handle encoded transaction values (KomodoPlatform#2133)
  fix(core): tendermint withdraws on hd accounts (KomodoPlatform#2130)
  fix(core): improve validation rules for table names (KomodoPlatform#2123)
  fix(test): improve log wait condition to fix taker restart test (KomodoPlatform#2125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants