Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tpu-v2): provide ethcoin support in tpu kickstart process #2300

Open
wants to merge 6 commits into
base: fix-tpu-v2-wait-for-payment-spend
Choose a base branch
from
Open

fix(tpu-v2): provide ethcoin support in tpu kickstart process #2300

wants to merge 6 commits into from

Conversation

laruh
Copy link
Member

@laruh laruh commented Dec 22, 2024 •
edited
Loading

This pr provides EthCoin support in kickstart handler for taker and maker swaps

@laruh laruh force-pushed the fix-tpu-v2-wait-for-payment-spend-kickstart branch from d08fa86 to df7778c Compare December 22, 2024 11:36
@mariocynicys mariocynicys self-assigned this Dec 23, 2024
@mariocynicys mariocynicys self-requested a review December 23, 2024 13:00
@mariocynicys mariocynicys removed their assignment Dec 23, 2024
borngraced
borngraced requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welldone, 3 minor notes

mm2src/mm2_main/src/lp_swap/swap_v2_common.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/src/lp_swap/swap_v2_common.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/src/lp_swap/swap_v2_common.rs Outdated Show resolved Hide resolved
mariocynicys
mariocynicys approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
LGTM

mm2src/mm2_main/src/lp_swap/swap_v2_common.rs Outdated Show resolved Hide resolved
onur-ozkan
onur-ozkan approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ping me once you are done with reviews @borngraced

borngraced
borngraced approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@onur-ozkan
Copy link
Member

Can you add test coverage for ETH ? Seems like we have one for UTXOs

komodo-defi-framework/mm2src/mm2_main/tests/docker_tests/swap_proto_v2_tests.rs

Lines 722 to 723 in ea5f307

#[test]
fn test_v2_swap_utxo_utxo_kickstart() {

@laruh
Copy link
Member Author

laruh commented Dec 24, 2024

Can you add test coverage for ETH ? Seems like we have one for UTXOs

komodo-defi-framework/mm2src/mm2_main/tests/docker_tests/swap_proto_v2_tests.rs

Lines 722 to 723 in ea5f307

#[test]
fn test_v2_swap_utxo_utxo_kickstart() {

I can, but it will be on sepolia and use feature flag

@onur-ozkan
Copy link
Member

I can, but it will be on sepolia and use feature flag

No problem I guess, better than nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

@borngraced borngraced borngraced approved these changes

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees
No one assigned
Labels
status: in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laruh @onur-ozkan @borngraced @mariocynicys