Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad-txns-nonfinal on UTXO HTLC refunds. #822

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Fix bad-txns-nonfinal on UTXO HTLC refunds. #822

merged 3 commits into from
Feb 19, 2021

Conversation

artemii235
Copy link
Member

@artemii235 artemii235 commented Feb 16, 2021 •
edited
Loading

@artemii235
WIP.
5fb2621
@artemii235
Use SwapOps::can_refund_htlc instead of lock_time + 3600
2ff914d 
to wait for the right time of HTLC refund during the swap.
@artemii235 artemii235 requested a review from cipig February 16, 2021 10:12
cipig
cipig previously approved these changes Feb 16, 2021
View reviewed changes
sergeyboyko0791
sergeyboyko0791 reviewed Feb 17, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please answer my comment?

mm2src/coins/utxo/utxo_standard.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Feb 17, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@artemii235 artemii235 merged commit a96e698 into mm2.1 Feb 19, 2021
@artemii235 artemii235 deleted the mm2.1-fix-refund-non-final branch February 19, 2021 08:26
@artemii235 artemii235 mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@cipig cipig cipig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemii235 @cipig @sergeyboyko0791