Mm2.1 wasm light wallet #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyboyko0791
commented
Mar 26, 2021
sergeyboyko0791
commented
- Implement and use the custom 'common::log::format_record' formatting of the log records instead of the built-in log4rs::encode::Encode to cut the file path
- Refactor common::executor for wasm32
- Separate mm2_lib into mm2_native_lib and mm2_wasm_lib
- Implement the spawn_rpc function for wasm32
* Use `wasm_bindgen_futures::spawn_local` instead of custom runtime implementation * Use `js_sys::Date::now` instead of defined in js `date_now` * Use 'setTimeout' within Timer
* Separate mm2_lib into mm2_wasm_lib and mm2_native_lib
* Separate common::lib into common::{native_log, wasm_log}
* Add wasm_build suite
* Add the spawn_rpc wasm-only version
* Use 'format_record' within MmLogAppender instead of built-in log4rs::encode::Encode * Change the 'common::for_tests::require_log_level' argument type * Document the mm2_main, mm2_rpc
* Also fix the build.rs warning
|
I've tested this branch on an Android emulator. It works fine, and I think, these changes may be merged :) |
|
Please note I've changed the formatting of the log entries forwarding from the |
* Remove hardcoded uri * Handle errors instead of panic
artemii235
reviewed
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.