Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking balance on taker swap start. #890

Merged
merged 6 commits into from
Apr 7, 2021
Merged

Fix checking balance on taker swap start. #890

merged 6 commits into from
Apr 7, 2021

Conversation

artemii235
Copy link
Member

#888
Using self.r().data.maker_coin resulted into empty ticker being passed to the dex_fee_rate. So when the maker coin was KMD the fee discount was not applied to the dex fee and the balance check could fail in the max_taker_vol case.

sergeyboyko0791
sergeyboyko0791 suggested changes Apr 7, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for one thing. Could you please look at my comments?

mm2src/common/for_tests.rs Show resolved Hide resolved
mm2src/lp_swap/taker_swap.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Apr 7, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approve it!

@artemii235 artemii235 merged commit d3e81c3 into mm2.1 Apr 7, 2021
@artemii235 artemii235 deleted the mm2.1-checking-max-taker-vol branch April 7, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemii235 @sergeyboyko0791