Set explicit 10 seconds timeout for P2P requests in our behavior. #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not hold orderbook lock during GetOrderbook request.
sergeyboyko0791
approved these changes
Apr 19, 2021
Not yet, the test hanged again after I set the 10 seconds timeout - most likely on Edit: what's also interesting: it hangs on Linux only, maybe it is something OS specific. |
|
Not yet, the test hanged again after I set the 10 seconds timeout - most likely on wait_peers. Will confirm this assumption when the test hangs again. Ok, thanks! I can look at the test today if there is a need to be done it as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not hold orderbook lock during GetOrderbook request.
#910