SLP and ARRR integration WIP. #954
Conversation
# Conflicts: # mm2src/coins/Cargo.toml # mm2src/coins/lp_coins.rs # mm2src/coins/z_coin.rs # mm2src/coins/z_coin/z_coin_tests.rs # mm2src/coins/z_coin/z_htlc.rs # mm2src/coins/z_coin/z_rpc.rs
| script_data: Script, | ||
| ) -> Result<UtxoTx, MmError<ZP2SHSpendError>> { | ||
| let current_block = coin.utxo_arc.rpc_client.get_block_count().compat().await? as u32; | ||
| let mut tx_builder = ZTxBuilder::new(consensus::MAIN_NETWORK, current_block.into()); |
There was a problem hiding this comment.
Only one question, do we need to support TEST_NETWORK for zcoin?
There was a problem hiding this comment.
Yes, for now, it's fine to stick with mainnet only and I plan to make the implementation more generic.
| } | ||
|
|
||
| impl SwapOps for ZCoin { | ||
| fn send_taker_fee(&self, _fee_addr: &[u8], _amount: BigDecimal) -> TransactionFut { todo!() } | ||
| fn send_taker_fee(&self, _fee_addr: &[u8], amount: BigDecimal) -> TransactionFut { | ||
| // TODO replace dummy locktime and watcher pub |
There was a problem hiding this comment.
Will you do this TODO in the next iteration?
There was a problem hiding this comment.
Sure, dexfee-related methods have to be changed significantly for ZCoin - will do it later.
|
|
||
| let outpoint = ZCashOutpoint::new(p2sh_tx.hash().into(), 0); | ||
| let tx_out = TxOut { | ||
| value: Amount::from_u64(p2sh_tx.outputs[0].value).expect("p2sh_tx transaction always contains valid amount"), |
There was a problem hiding this comment.
I think we have to check the count of the transaction outputs here
There was a problem hiding this comment.
Good point, we can occasionally get the transaction not having transparent inputs and outputs at all. Will do it in the next iterations.
| @@ -67,6 +67,8 @@ async fn enable_coins_eth_electrum( | |||
| ); | |||
| replies.insert("ETH", enable_native(mm, "ETH", eth_urls).await); | |||
| replies.insert("JST", enable_native(mm, "JST", eth_urls).await); | |||
| #[cfg(feature = "zhtlc")] | |||
| replies.insert("ZOMBIE", enable_native(mm, "ZOMBIE", eth_urls).await); | |||
There was a problem hiding this comment.
Is it correct to specify the same urls as we do for the ETH coin?
There was a problem hiding this comment.
ETH URLs are simply ignored for native UTXO mode so it's fine 🙂
#927 #701