Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP1559 Fee management methods and configs #375

Merged
merged 33 commits into from
Nov 17, 2024
Merged

Add EIP1559 Fee management methods and configs #375

merged 33 commits into from
Nov 17, 2024

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Nov 4, 2024

harsenyan3 and others added 28 commits July 18, 2024 11:56
@harsenyan3
Added documentation for Gas Fee Estimator RPC methods
9e4b446 
Added docs for:
1. start_gas_fee_estimator
2. stop_gas_fee_estimator
3. get_eth_estimated_fee_per_gas
@harsenyan3
.
07c3a09
@harsenyan3
example subheading set
9e51768
@harsenyan3
fixed common structures
c6d055a
@harsenyan3
fixed trailing comma in json request
af9242a
@harsenyan3
link to star_gas_fee_estimator fixed
9bec386
@harsenyan3
fixed url x2
3424c3a
@smk762
Merge branch 'dev' into add/gas-fee-estimator-docs
9b8c59a
@smk762
linting
ee5304d
@smk762
linting
5db1c3b
@gcharang
fix commas in jsons
1004ff2
@smk762
gas estimate methods renamed
6694a88
@smk762
Merge branch 'dev' into add/gas-fee-estimator-docs
1b397d4
@smk762
rename methods, fix lint errors
f38819e
@smk762
Add notes from KDF PR 2051
bf75b99
@smk762
Merge branch 'add/gas-fee-estimator-docs' into update/kdf/sign_raw_tr…
a117530 
…ansaction
@smk762
add pay_for_gas object
fc38f95
@smk762
move fee methods into new folder
fd529a4
@smk762
rm old folder files
87a11d9
@smk762
adds gas_api param to MM2.json config doc
bce576a
@smk762
add gas_fee_estimator field to listing guide
ec34e41
@smk762
add min_wait_time and max_wait_time for gas fee estimation
7ae819d
@smk762
add start/stop eth fee estimator
544ae2e
@smk762
add get/set fee policy methods
ef079fb
@smk762
Add overview page for fee management
006e39c
@smk762
linting
aab8d8b
@smk762
update sign_raw_tx examples
182d82b
@smk762
add sign_raw_transaction examples to postman
04bc4e8
@smk762 smk762 requested review from dimxy and gcharang November 4, 2024 12:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Preview for merge commit: a168dc6, available on cloudflare at: https://f1c44e10.komodo-docs.pages.dev/en/docs/

@smk762 smk762 changed the title Update/kdf/sign raw transaction Add EIP1559 Fee management methods and configs Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Preview for merge commit: a168dc6, available on cloudflare at: https://db6c2a68.komodo-docs.pages.dev/en/docs/

@smk762
Copy link
Contributor Author

smk762 commented Nov 5, 2024

Note:

Plz be aware that gas fee estimator rpcs

start_eth_fee_estimator
stop_eth_fee_estimator

will be removed in this PR 2172 as it will be managed by the new streaming API rpc "fee_estimator::enable"

@smk762
Copy link
Contributor Author

smk762 commented Nov 5, 2024

@dimxy Should we PR to coins repo for setting "gas_fee_estimator": "simple" by default?

@dimxy
Copy link

dimxy commented Nov 5, 2024

@dimxy Should we PR to coins repo for setting "gas_fee_estimator": "simple" by default?

Yes currently it is configured in the coins file and should be set explicitly.
But this code is deprecated and will be replaced by a more general event streaming feature. I prepared an update for gas fee estimator into the event streaming, in that update fee estimator is configured via the coin activation request (instead of coins file) and yes, it will default to the 'simple' option. I will create this fix as a PR when the event streaming PR is merged.

dimxy
dimxy approved these changes Nov 8, 2024
View reviewed changes
Copy link

@dimxy dimxy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(with the remark that start_eth_fee_estimator stop_eth_fee_estimator rpcs will be removed when event streaming PR is merged.
Also the gas fee provider config will change in this PR)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

Preview for merge commit: 2712c2f, available on cloudflare at: https://5f43cbc5.komodo-docs.pages.dev/en/docs/

@smk762 smk762 mentioned this pull request Nov 11, 2024
Open
@gcharang gcharang merged commit 9867dbc into dev Nov 17, 2024
1 check passed
@github-actions GitHub Actions
Copy link

Preview for merge commit: 7238756, available on cloudflare at: https://f26c9e98.komodo-docs.pages.dev/en/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimxy dimxy dimxy approved these changes

@gcharang gcharang Awaiting requested review from gcharang

@AndrewDelaney AndrewDelaney Awaiting requested review from AndrewDelaney

@ShantanuSharma9873 ShantanuSharma9873 Awaiting requested review from ShantanuSharma9873

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smk762 @dimxy @gcharang @harsenyan3