Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build image and devcontainer config #147

Merged
merged 35 commits into from
Jul 13, 2024
Merged

Conversation

takenagain
Copy link
Collaborator

@takenagain takenagain commented May 21, 2024

Add two docker files to the repository to enable:

  • Containerised builds for Android, and
  • Containerised development via devcontainer

NOTE: There are known issues with building this repository using docker on ARM-based systems (e.g. M-series Macs, Raspberry Pi):

Usage

Use the following commands to build locally on x86 systems using Docker:

sh .docker/build_apk_release.sh

To build in GitHub Codespaces open a terminal and run:

flutter build apk --release

Open in GitHub Codespaces

In both instances, the apk file should appear in build/app/outputs/flutter-apk/app-release.apk

Docker image source: Cirrus Labs Android SDK Images

CharlVS and others added 15 commits October 20, 2023 18:38
0.8.0 Release (stable): UI revamp, bug fixes and coins update
`0.9.0` RC - Net ID migration and file sharing fixes
Only Linux and WSL on x86 are supported at the moment
[RC] `0.9.1`: Chart & Order Book Fixes + Sync assets
* Update coins to SSL config

* Rename references to SSL coin config

* Prefer SSL, but fall back to TCP if not available.

`coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available.

* Sync latest TCP file from coins repo

* bump target SDK 

https://developer.android.com/google/play/requirements/target-sdk

Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com>

* Bump app build

Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com>

---------

Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com>
Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com>
Co-authored-by: CharlVS <77973576+CharlVS@users.noreply.github.com>
@takenagain takenagain requested a review from CharlVS May 21, 2024 15:35
@takenagain takenagain self-assigned this May 21, 2024
Copy link
Member

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the container is only working on Linux but you are are investigating the m1 support issues for which there should hopefully be a solution since a big portion of the devs are running this setup.

takenagain and others added 4 commits May 21, 2024 22:19
Write permission denied to `/opt/android-sdk-linux`
Use a build matching the current architecture rather than downloading a prebuilt archive
* Refactor to fetch Defi binaries from GH releases

Refactor to fetch Defi binaries from GH releases since they are built in a secure environment instead of the automated CI builds.

* Fix script to use version tag

Fix the script to use a version tag instead of a hash, as GH’s API does not support fetching a release tied to a specific commit. In the future, we can investigate if there’s an alternate way to verify/validate that the release build is indeed built from a given hash so we can change from a tag ref to a hash ref.

* Fix bug in API fetch script

Fix the API binary fetch script

Ravioli ravioli
@CharlVS CharlVS added documentation Improvements or additions to documentation enhancement New feature or request labels May 22, 2024
takenagain and others added 6 commits May 22, 2024 15:24
Remove references to 3rd party dockerfiles, allow for local image tagging and simplify code review.
Credit to https://github.com/cirruslabs/docker-images-android/tree/master
Fix bug in API fetch script where fetching would fail if the android lib folders didn’t already exist.
Use local tagged image instead of the 3rd party image
@takenagain takenagain marked this pull request as ready for review May 23, 2024 11:52
@CharlVS CharlVS requested a review from smk762 May 23, 2024 14:37
@CharlVS CharlVS added the QA Ready for QA testing label May 23, 2024
@CharlVS CharlVS changed the base branch from master to dev May 23, 2024 14:37
@CharlVS CharlVS mentioned this pull request May 31, 2024
API was built in image to reduce Codespaces startup time, but ended up increasing the already large image size
4 cores, 16GB RAM and 32GB storage is the minimum requirements for the API to build successfully from source.
@CharlVS CharlVS merged commit fe814ae into dev Jul 13, 2024
2 checks passed
@CharlVS CharlVS deleted the feature/docker-build branch July 13, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request QA Ready for QA testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants