-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build image and devcontainer config #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.8.0 Release (stable): UI revamp, bug fixes and coins update
`0.9.0` RC - Net ID migration and file sharing fixes
sync master
sync master
Only Linux and WSL on x86 are supported at the moment
[RC] `0.9.1`: Chart & Order Book Fixes + Sync assets
* Update coins to SSL config * Rename references to SSL coin config * Prefer SSL, but fall back to TCP if not available. `coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available. * Sync latest TCP file from coins repo * bump target SDK https://developer.android.com/google/play/requirements/target-sdk Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> * Bump app build Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> --------- Signed-off-by: Kadan Stadelmann <ca333@users.noreply.github.com> Signed-off-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Co-authored-by: CharlVS <77973576+CharlVS@users.noreply.github.com>
…let-mobile into feature/docker-build
Also update dockerfile
This reverts commit 0bde503.
CharlVS
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the container is only working on Linux but you are are investigating the m1 support issues for which there should hopefully be a solution since a big portion of the devs are running this setup.
Write permission denied to `/opt/android-sdk-linux`
Use a build matching the current architecture rather than downloading a prebuilt archive
* Refactor to fetch Defi binaries from GH releases Refactor to fetch Defi binaries from GH releases since they are built in a secure environment instead of the automated CI builds. * Fix script to use version tag Fix the script to use a version tag instead of a hash, as GH’s API does not support fetching a release tied to a specific commit. In the future, we can investigate if there’s an alternate way to verify/validate that the release build is indeed built from a given hash so we can change from a tag ref to a hash ref. * Fix bug in API fetch script Fix the API binary fetch script Ravioli ravioli
CharlVS
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
May 22, 2024
Remove references to 3rd party dockerfiles, allow for local image tagging and simplify code review. Credit to https://github.com/cirruslabs/docker-images-android/tree/master
Fix bug in API fetch script where fetching would fail if the android lib folders didn’t already exist.
Use local tagged image instead of the 3rd party image
This reverts commit 95ce8bf.
Also standardise base images to ubuntu:22.04
Leftover artefact from previous build stage setup
Open
API was built in image to reduce Codespaces startup time, but ended up increasing the already large image size
4 cores, 16GB RAM and 32GB storage is the minimum requirements for the API to build successfully from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
QA
Ready for QA testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two docker files to the repository to enable:
NOTE: There are known issues with building this repository using docker on ARM-based systems (e.g. M-series Macs, Raspberry Pi):
Usage
Use the following commands to build locally on x86 systems using Docker:
To build in GitHub Codespaces open a terminal and run:
In both instances, the apk file should appear in
build/app/outputs/flutter-apk/app-release.apk
Docker image source: Cirrus Labs Android SDK Images