-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressbook restyle #1741
Addressbook restyle #1741
Conversation
Need little more spacing under the combobox. too much spacing under address input expanded box perhaps too big when only a few coins to select. smaller font for "use standard network address" so it fits on 2 lines. Error message could be reduced to omit the bits before the second Unable to select coins that are not enabled (optional fr: make like bestorders with fade and option to enable on click). If QTUM not enabled, I can still attempt to add a QRC-20 address, but will get a validation error. After confirming entries, main screen shows "no registered addresses". This does not update until going to other tab (e.g. wallet) and then back. Might be good to have sight different background for the contact address list area (example below): Addressbook entries not visible after restarting app. Seems cause of this was wallet name existing as folder (from previous builds, folder was datestamped almost 1 year ago). Not a problem for this PR, but noting for potential future support queries.
After deleting folder, everything fine - new file created, entries visibile on subsequent starts. |
|
A lot of stuff related to asset network standards have been hardcoded in the frontend in several places. When we will add a new one it will not be so trivial. This brings us to something we will need to implement in next patches: some models (e.g. coins model) in the backend are poorly designed for our current needs and some are still missing (e.g. network standard model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good thanks :)
Closes #1464
Closes #1770