Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix infinite fees loading issue #2114

Merged
merged 7 commits into from
Dec 1, 2022
Merged

fix infinite fees loading issue #2114

merged 7 commits into from
Dec 1, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 25, 2022 •
edited
Loading

closes #2112

  • Removes extra trade_preimage rpc calls
  • Removes extra cap_volume rpc calls (slightly faster simple mode loading)

To test:

  • select different orders in quick succession. Fees should display, not attempt to reload (no busy indicator after fees shown) and not get in a state of perpetual busy indicator on both pro and simple mode

@smk762 smk762 requested review from a user, tonymorony, SirSevenG and Canialon November 25, 2022 17:10
@Canialon
Copy link

at first glance, the issue looked fixed but now I can call this result:

image

@tonymorony
Copy link

tonymorony commented Nov 27, 2022 •
edited
Loading

confirm, this validation should happen before user clicked "Start swap" button

image

@smk762 smk762 mentioned this pull request Nov 28, 2022
Closed
@tonymorony tonymorony marked this pull request as draft November 28, 2022 17:50
@smk762 smk762 marked this pull request as ready for review November 30, 2022 20:26
Canialon
Canialon approved these changes Nov 30, 2022
View reviewed changes
Copy link

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@smk762 smk762 merged commit 06f1c20 into dev Dec 1, 2022
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
@smk762 smk762 deleted the debug_fees branch August 7, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Canialon approved these changes

@SirSevenG SirSevenG SirSevenG approved these changes

@tonymorony tonymorony Awaiting requested review from tonymorony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Infinity loading fees
4 participants
@smk762 @Canialon @tonymorony @SirSevenG