Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z coin optional date #2367

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Z coin optional date #2367

merged 4 commits into from
Oct 19, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 21, 2023

This PR tests the dev branch API with includes KomodoPlatform/komodo-defi-framework#1967

image

For syncing ARRR, the following cases apply:

  • If no prior cache and use_date if off, sync starts 2 days in the past.
  • If no prior cache and use_date if on, sync starts on block height derived from date (rounded to nearest 1000).
  • If prior cache exists and use_date if off, sync continues from prior cache height.
  • If prior cache exists and use_date if on, and date value has changed since last sync, sync starts on block height derived from date (rounded to nearest 1000).
  • If prior cache exists and use_date if on, and date value has not changed since last sync, sync continues from prior cache height.

To test:

  • log in and activate ARRR to cover the cases above and confirm app performs as expected.

@cipig
Copy link
Member

cipig commented Sep 21, 2023

this one really fixes my problem

i have this
image

and after restart it doesn't overwrite the existing DB any more, it continues from where it stopped

@cipig
Copy link
Member

cipig commented Sep 21, 2023

image

if i just check "use date sync" and keep the date same it starts from

21 06:09:48, coins::z_coin::z_rpc:389] INFO Older/Newer sync height detected!, rewinding walletdb to new height: Some(2490000)
21 06:10:05, coins::z_coin::z_rpc:497] INFO Older/Newer sync height detected!, rewinding blocks_db to new height: 2490000
21 06:10:12, coins::z_coin::z_rpc:882] INFO (Re)starting light_wallet_db_sync_loop for ARRR, blocks per iteration 5000, interval in ms 0

after restart, overwriting the existing DB
my DB started originally in 2021

checked all cases with "If prior cache exists", the last 3 ones... working as expected

cipig
cipig previously approved these changes Sep 21, 2023
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all 5 cases work as expected
thanks for the fix

@smk762 smk762 dismissed cipig’s stale review September 21, 2023 09:23

The merge-base changed after approval.

CMakeLists.txt Outdated Show resolved Hide resolved
cipig
cipig previously approved these changes Oct 1, 2023
@smk762 smk762 merged commit 84abf83 into dev Oct 19, 2023
6 of 8 checks passed
@smk762 smk762 mentioned this pull request Dec 20, 2023
@smk762 smk762 deleted the z-coin-optional-date branch January 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants