Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokensv2 RPC help output issues #404

Open
NutellaLicka opened this issue Mar 1, 2021 · 1 comment
Open

Tokensv2 RPC help output issues #404

NutellaLicka opened this issue Mar 1, 2021 · 1 comment

Comments

@NutellaLicka
Copy link

This issue tracker is only for technical issues related to komodod

General Komodo questions and/or support requests and are best directed to Discord

Describe the issue

With the new PR to the Research branch that added Tokenv2, the Tokens RPC help command now shows both sets of tokensv1 and tokensv2 RPC in the same list. The other CC's are split by v1 and a separate v2 section below that. It also looks as though some of the help RPC's don't show the v2 version. I double checked in the research branch and found the v2 version in there, so I'm not sure where the disconnect is.

For example:
tokenask numtokens tokenid price shows twice (once for v1, a second time for v2), but I found the code below
https://github.com/KomodoPlatform/komodo/blob/research/src/rpc/tokensrpc.cpp#L699

tokenid bidtxid also shows twice but I cannot find it within the rpc.cpp

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. komodo-cli -ac_name=TKLTEST help

Expected behaviour

The tokensv1 and tokensv2 sections should be separate like the Oracles v1/v2, for example.

Actual behaviour + errors

Nil

The version of Komodo you were using:

"KMDversion": "0.6.1",

Machine specs:

Not applicable

Any extra information that might be useful in the debugging process.

Not applicable

Do you have a backup of ~/.komodo directory and/or take a VM snapshot?

Not applicable

@NutellaLicka NutellaLicka changed the title Tokensv2 help RPC Tokensv2 RPC help output issues Mar 1, 2021
@dimxy
Copy link
Collaborator

dimxy commented May 6, 2021

this should be fixed in the research now

who-biz pushed a commit to who-biz/komodo that referenced this issue Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants