Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

komodo_notaries is not thread safe #487

Open
jmjatlanta opened this issue Sep 9, 2021 · 0 comments
Open

komodo_notaries is not thread safe #487

jmjatlanta opened this issue Sep 9, 2021 · 0 comments

Comments

@jmjatlanta
Copy link

jmjatlanta commented Sep 9, 2021

calls to komodo_notaries() sometimes update local static arrays without protecting memory. See

didinit[kmd_season-1] = 1;

A suggested fix would be a mutex around the area that checks or modifies the array. A Read/Write mutex may be a good idea here, as it seems this is an often called function, and the data in the arrays are not updated near as much as they are read.

who-biz pushed a commit to who-biz/komodo that referenced this issue Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant