Expand unit test coverage

[jmjatlanta]

While not strictly "unit testing", more like mini system/integration testing, developers sometimes need to test their code alongside portions of the existing system. In the case that brought about this change, a new CryptoCondition needed to be tested in the context of the whole create transaction/spend transaction process.

testutils already existed to do some of this, but it did not seem to be used often. Existing functions were collected and adjusted to work inside a class. Now simple chain transactions can be tested by writing a gtest:

TestChain chain; // start a new chain

// Basic user wallets
auto notary = chain.AddWallet(chain.getNotaryKey());
auto alice = chain.AddWallet();
auto bob = chain.AddWallet();

CBlock lastBlock = chain.generateBlock(); // Genesis block

// turn on CryptoConditions
ASSETCHAINS_CC = 1;

{
    // create a transaction that gives some coin to Alice
    CValidationState returnState = notary->Transfer(alice, 100000);
    // verify everything worked
    EXPECT_TRUE( returnState.IsValid() );
    // mine a block
    lastBlock = chain.generateBlock(); // vtx[0] is unrelated, vtx[1] is ours
}
{
    // notary gives some coin to Bob, with the stipulation that he pay some kind of miner fee
    auto notaryPrevOut = notary->GetAvailable(200000);
    CMutableTransaction tx;
    CTxIn notaryIn;
    notaryIn.prevout.hash = notaryPrevOut.first.GetHash();
    notaryIn.prevout.n = notaryPrevOut.second;
    tx.vin.push_back(notaryIn);
    // give some coin to bob, but he must pay something to the miners
    CC* bobMustPayFee = MakeCCcond1(EVAL_INCLMINERFEE, bob->GetPubKey());
    CTxOut bobOut;
    bobOut.scriptPubKey = CCPubKey(bobMustPayFee);
    bobOut.nValue = 200000;
    tx.vout.push_back(bobOut);
    // give the rest back to the notary
    CTxOut notaryOut;
    notaryOut.scriptPubKey = GetScriptForDestination(notary->GetPubKey());
    notaryOut.nValue = notaryPrevOut.first.vout[1].nValue - 200000;
    tx.vout.push_back(notaryOut);
    // sign it
    uint256 hash = SignatureHash(notaryPrevOut.first.vout[1].scriptPubKey, tx, 0, SIGHASH_ALL, 0, 0);
    tx.vin[0].scriptSig << notary->Sign(hash, SIGHASH_ALL);
    // send it to the mempool
    CTransaction fundBob(tx);
    CValidationState returnState = chain.acceptTx(fundBob);
    // verify everything worked
    EXPECT_TRUE( returnState.IsValid() );
    // mine a block
    CBlock currentBlock = chain.generateBlock();
    // the wallet doesn't understand these transactions, so add this vout to Bob's wallet manually
    bob->AddOut(currentBlock.vtx[1], 0);
    cc_free(bobMustPayFee);
}

[jmjatlanta]

In the commits above I have migrated various zcash and bitcoin tests to include them in the run of komodo-tests

[dimxy]

this should be rebased to include the S6 updates

[dimxy]

could it be a named constant instead of '100'?

[jmjatlanta]

I would like to replace it with something other than a global. It is only used in wallet functions, so I put it there. See 8db798b

[dimxy]

maybe we could use a named constant here (isn't it originalCoinbaseMaturity)?

[jmjatlanta]

Removed MAX_REORG_LENGTH, see comment above

[dimxy]

aha, renamed to zcash_gtest as in fact it tests just zcash features

[tonymorony]

these changes implemented in combined PR: #559