Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libsnark, libgmp, mini-gmp #613

Merged
merged 50 commits into from
Aug 19, 2024
Merged

Remove libsnark, libgmp, mini-gmp #613

merged 50 commits into from
Aug 19, 2024

Commits on Mar 1, 2024

  1. tests: add bitcoin_base58{en,de}code test

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    444ebdb View commit details
    Browse the repository at this point in the history

  2. tests: base58operations, switch from smart pointer to vector

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e39a7d8 View commit details
    Browse the repository at this point in the history

  3. tests: base58operations, add special cases, add encode/decode replace… 

    …ments
    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e494521 View commit details
    Browse the repository at this point in the history

  4. get rid of mini-gmp library

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1b9b181 View commit details
    Browse the repository at this point in the history

  5. tests: base58operations, add wif decode/encode with bitcoin_ functions

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8d6683f View commit details
    Browse the repository at this point in the history

  6. payments cc: add comment about mpz_set_lli

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c24418f View commit details
    Browse the repository at this point in the history

  7. tests: add part of RewardsTest

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    053f3f8 View commit details
    Browse the repository at this point in the history

  8. tests: add boilerplate code for 2nd part of RewardsTest 

    TODO: solve memory leak in RewardsCalc (seems in few places we totally
forgot about call `mpz_clear` to clear the memory allocated for each
used variable).
    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    53ea5d5 View commit details
    Browse the repository at this point in the history

  9. rewards: fix small memory leak in RewardsCalc

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7eac20c View commit details
    Browse the repository at this point in the history

  10. tests: RewardsTest completed

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b71c2ff View commit details
    Browse the repository at this point in the history

  11. remove gmp functions from rewards.cpp, use arith_uint256 math instead

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a564dfc View commit details
    Browse the repository at this point in the history

  12. tests: RewardsTest Improve compatibility with other tests. 

    If tests in other translation units leave pblocktree and pcoinsTip
in an initialized state, free the memory and set it to nullptr.
    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    10946fe View commit details
    Browse the repository at this point in the history

  13. tests: PaymentsTest add BnToString, BnFitsCAmount for payments.cpp

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8841b60 View commit details
    Browse the repository at this point in the history

  14. uint256: remove ridiculous pointer comparsion

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    79b0f2c View commit details
    Browse the repository at this point in the history

  15. tests: prevent MAX_MONEY altering during ParseArgumentsTests

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c612002 View commit details
    Browse the repository at this point in the history

  16. remove gmp functions from payments.cpp, use arith_uint256 math instead

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b86a3ec View commit details
    Browse the repository at this point in the history

  17. remove dilithium and musig from the CC, due to upcoming secp256k1 update

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    86f6a58 View commit details
    Browse the repository at this point in the history

  18. Always skip verification for old Sprout proofs

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c8d7e33 View commit details
    Browse the repository at this point in the history

  19. Remove ability to create non-Groth16 Sprout JSDescriptions

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    56ce7e5 View commit details
    Browse the repository at this point in the history

  20. Use Sapling JSDescriptions in Boost tests

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c436434 View commit details
    Browse the repository at this point in the history

  21. Remove non-Groth16 Sprout proofs from joinsplit gtests

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    6e85e17 View commit details
    Browse the repository at this point in the history

  22. Remove libsnark code for pre-Sapling Sprout proofs

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4f6f35f View commit details
    Browse the repository at this point in the history

  23. Remove pre-Sapling Sprout circuit

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    45a2dfb View commit details
    Browse the repository at this point in the history

  24. Revert "Check if OpenMP is available before using it"

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    39bf8ec View commit details
    Browse the repository at this point in the history

  25. build: More OpenMP / Multicore related things removal

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1f6ce0d View commit details
    Browse the repository at this point in the history

  26. Remove libsnark from build system

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a9d21d3 View commit details
    Browse the repository at this point in the history

  27. Remove *_7776 files from tracking

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    97fe680 View commit details
    Browse the repository at this point in the history

  28. Remove libsnark

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    781efa4 View commit details
    Browse the repository at this point in the history

  29. Remove libsnark from build and depends system. 

    Unlike ZCash, we still have libsnark included in both the
build and dependency systems. Therefore, this commit should
remove all the libsnark-related components from both systems.

zcash@26a8f68
    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bd867d6 View commit details
    Browse the repository at this point in the history

  30. More remove libnark 

    removal of missed locations that reference libnark
    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f9610fc View commit details
    Browse the repository at this point in the history

  31. remove zcsymbols.txt

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bb60054 View commit details
    Browse the repository at this point in the history

  32. Remove libgmp

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dcde6da View commit details
    Browse the repository at this point in the history

  33. test: Require minimum of Sapling for all RPC tests

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    80327be View commit details
    Browse the repository at this point in the history

  34. rpc: Use Sapling transactions in zc_raw_joinsplit

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    012dc26 View commit details
    Browse the repository at this point in the history

  35. Use Sapling JSDescriptions in gtests 

    TODO:

- Migrate test utilities to generate Sapling-type Sprout proofs
- Rename methods to include Sprout

etc.
    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5a0465f View commit details
    Browse the repository at this point in the history

  36. Remove makeGrothProof argument from JoinSplit::prove

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    044fea0 View commit details
    Browse the repository at this point in the history

  37. Stop fetching old Sprout parameters 

    We aren't automatically deleting them yet.
    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d05fda5 View commit details
    Browse the repository at this point in the history

  38. Add libsnark removal to notable changes

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    6b23a8f View commit details
    Browse the repository at this point in the history

  39. Move AbortNode to the top of main.cpp 

    It is in an anonymous namespace, so it needs to be above all code in the
file that uses it.
    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    592b57b View commit details
    Browse the repository at this point in the history

  40. Add comments on IBD and nMinimumChainWork

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    cdc6740 View commit details
    Browse the repository at this point in the history

  41. Remove obsolete CreateJoinSplit and GenerateParams binaries

    @str4d @DeckerSU
    str4d authored and DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c2aa940 View commit details
    Browse the repository at this point in the history

  42. update KMD checkpoints

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    58351c3 View commit details
    Browse the repository at this point in the history

  43. add additional params logging with -debug=params

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7a2b3a4 View commit details
    Browse the repository at this point in the history

  44. get rid of check right port condition in dns address seed thread 

    Since nDefaultPort is always equal to ASSETCHAINS_P2PPORT and
DNS records do not contain any information about the port number,
the condition to check the correct port will always be true.
Therefore, it can be removed.
    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    402d1fe View commit details
    Browse the repository at this point in the history

  45. add AC checkpoints, KMD checkpoints now include only normal PoW blocks

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    cf5690f View commit details
    Browse the repository at this point in the history

  46. Update .gitignore

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    10f2938 View commit details
    Browse the repository at this point in the history

  47. fix stringop-overflow error in CheckCODAimport

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dc37452 View commit details
    Browse the repository at this point in the history

  48. Remove excessive gmp.h header in GMPArithTests

    @DeckerSU
    DeckerSU committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3f3677c View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. fix messages in fetch-params.sh, fetch-params-alt.sh

    @DeckerSU
    DeckerSU committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    177ba90 View commit details
    Browse the repository at this point in the history

  2. remove unused patches (*.patch) in repo's root

    @DeckerSU
    DeckerSU committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5400507 View commit details
    Browse the repository at this point in the history