Release candidate #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
…egarding arguments
add partial impl of api/consensus/tipstate walletd endpoint
…t}::{hash} walletd endpoints
add deserialize_null_as_empty_vec to utils module
add HelperError::FindWhereUtxoSpent
add a FIXME dev comment regarding Deserialize impl of Event
…hange Prior to this change, preimages included in SatisfiedPolicy were Vec<u8> They are now [u8; 32]
introduce id field to SiafundElement and SiacoinElement remove scoid: prefix for serde of SiacoinOutputId change merkle_proof field of StateElement from Option<Vec<Hash256>> to Vec<Hash256> - serde(default) should handle both `null` and `[]` as empty Vec<> Leave FIXME doc comment regarding the need for additional unit tests for these changes
…t strictly needed but it better matches the Go implementation
…tateElement consensus changes from Sia Go - removed id field from StateElement
fix V2FileContractElement encoding
… inside komodoplatform/sia-core repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
incorporate and security review types: Switch to fixed-length PolicyHash preimage SiaFoundation/core#207 ref
implement methods in V2TransactionBuilder for atomic swap signing. Requires
impl SatisfyPolicy for AtomicSwaprefGeneric error handling in the dispatcher. Current error handling still has remnants of now refactored dispatcher. ref
Move the example client to a rust doc example
Wrap all relevant unit tests with
cross_target_testsexampleMigrate docker test framework from Komodo DeFi Framework into Sia Rust. There are tests throughout the codebase that rely on a hardcoded URL to a walletd index node. Remove these in favor of mocked API or walletd docker containers.
Implement the remaining file contract related types for V2Transaction. This is not critical for final delivery as we can safely ignore this data in deserialization and will never do serialization. At a minimum, replace
todo!()s with error handling or empty data. ref1 ref2