Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dispatcher): use generic error placeholder for the ApiClient #7

Open
wants to merge 1 commit into
base: release_candidate_1
Choose a base branch
from

Conversation

mariocynicys
Copy link
Collaborator

Used a type Error for the ApiClient that depends on the concrete impl.

note: avoided calling request.to_endpoint_schema()? in to_data_request so that the error from to_endpoint_schema isn't exposed in the trait ApiClient and not have to comply with Self::Error in non-concrete impls.

@Alrighttt
Copy link
Member

Hey, good work, thank you. I've created quite a few conflicts in https://github.com/KomodoPlatform/sia-rust/tree/feat/fetch-utxos-helper .

I am merging feat/fetch-utxos-helper. Please leave this open, and I will handle the conflicts. Some portions of your code are no longer needed such as the ApiClientHelpersError related code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants