Set PYTHON_INCLUDE_DIR and PYTHON_LIBRARY during installation #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @unexploredtest, @axsaucedo, Superchunk. This should fix #221.
Description
Finding Python for CMake is a known issue. This PR from PyTorch, while not directly related to fixing Python installation issues, shows a tried-and-tested way to help CMake find Python. In particular, the following lines are of interest:
I opted for the first option, as the second option gave an incorrect directory on my machine (but the installation still worked).
Notes
It's worth noting that
FindPython3
(for CMake 3.12+) does a similar thing. See here