Fixed Vulkan deprecation warning #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
|
Good spot - do you know if this has to be under any macro guard (that validates particular versions of vulkan headers)? Or is it already depricated from 1.2? |
|
As far as I get it this is deprecated since it may return the wrong result in some cases. More on that can be found here: https://github.com/KhronosGroup/Vulkan-Hpp/blob/master/README.md#deprecated-elements Yes, it's already deprecated in 1.2: https://github.com/KhronosGroup/Vulkan-Hpp/blob/v1.2.203/README.md#deprecated-elements |
|
Awesome - thanks for having a deeper look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
ResultValue<T>should be accessed explicitly. Implicit access is deprecated.Fixes the second half of: #278