Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fmt 8.0.0 enum classes are not being implicitly converted to int any more.
Refference: fmtlib/fmt#1841
Since I have to use fmt 8.0 and therefore can not use the one provided by Kompute, I defined a format extension for
kp::Tensor::TensorDataTypes
andkp::Tensor::TensorTypes
.I'm not too sure if they are required in both classes
Tensor.hpp
andKompute.hpp
.Also let me know if the formatting of the code is fine that way, since I was not able to find any guidelines (e.g. a
.clang-format
file).