Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added .clang-format file and formatted everything #286

Merged
merged 3 commits into from
May 4, 2022
Merged

Added .clang-format file and formatted everything #286

merged 3 commits into from
May 4, 2022

Conversation

COM8
Copy link
Contributor

@COM8 COM8 commented May 2, 2022

This PR adds a .clang-format file based on the configuration specified in the Makefile.
I also run it over all files in the repo once.

@COM8
Added .clang-format file and formatted everything
24cd307 
Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
axsaucedo
axsaucedo requested changes May 2, 2022
View reviewed changes
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution - thank you! I added comments on the files that we should look to skip, but other than that looks good

external/bin/xxd.c Outdated Show resolved Hide resolved
python/src/main.cpp Outdated Show resolved Hide resolved
src/include/kompute/shaders/shaderlogisticregression.hpp Outdated Show resolved Hide resolved
test/compiled_shaders_include/kompute_test/shaders/shadertest_logistic_regression.hpp Outdated Show resolved Hide resolved
test/compiled_shaders_include/kompute_test/shaders/shadertest_op_custom_shader.hpp Outdated Show resolved Hide resolved
vk_ndk_wrapper_include/kompute_vk_ndk_wrapper.cpp Outdated Show resolved Hide resolved
vk_ndk_wrapper_include/kompute_vk_ndk_wrapper_patch.hpp Outdated Show resolved Hide resolved
vk_ndk_wrapper_include/kompute_vk_ndk_wrapper.hpp Outdated Show resolved Hide resolved
@COM8
Not formatting automatically generated and lib files
e4a9b9d 
Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
@COM8
Copy link
Contributor Author

COM8 commented May 2, 2022

Those are things I could have thought about :D
Fixed it.

@axsaucedo
Copy link
Member

Nice one! Thanks for updating it so fast - just having a look. I can see that the format command now reflects the file command, but I can see that also the examples folder also has some udpates - did you run the command through the Makefile? Or did you run it through a different command? Just thinking it makes sense that we also format the examples but may be worth making the command in the makefile consistent with the changes

@COM8
Updated makefile clang format command
21b9943 
Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
@COM8
Copy link
Contributor Author

COM8 commented May 4, 2022

I've used this script: https://github.com/eklitzke/clang-format-all/blob/master/clang-format-all
But you are right it makes sense to reflect the changes in the Makefile.
I fixed that.

@axsaucedo
Copy link
Member

Perfect - looks great. Nice one @COM8 , merging - thanks for the contribution

@axsaucedo axsaucedo merged commit de46d30 into KomputeProject:master May 4, 2022
@COM8 COM8 deleted the clang-format branch May 4, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@COM8 @axsaucedo