Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compiler warnings #289

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

COM8
Copy link
Contributor

@COM8 COM8 commented May 20, 2022

In preparation for the build system rewrite where -Wall -Wextra -Wpedantic -Werror will be set by default, this PR fixes all warnings reported.

I removed

if (this->mQueueIndex < 0) {
    throw std::runtime_error("Kompute Sequence queue index not provided");
}

without any replacement since mQueueIndex will be always set in the constructor anyway.

Fixes: #278

Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
@COM8 COM8 force-pushed the compiler_warnings branch from 1846c5e to 88b06ad Compare May 20, 2022 07:43
Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
@axsaucedo
Copy link
Member

Nice - this is really good thank you @COM8 , we can now close #278

@axsaucedo axsaucedo merged commit e2485bb into KomputeProject:master May 20, 2022
@COM8 COM8 deleted the compiler_warnings branch May 20, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build cleanly without warnings
2 participants