Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes two mistakes in comments and removes one unused vk::MappedMemoryRange #301

Merged
merged 3 commits into from
Sep 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions examples/godot_examples/gdnative_shared/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,15 @@ git clone --branch 3.2 https://github.com/godotengine/godot-cpp
cd godot-cpp
```

Then we can get all the subomdules
Then we can get all the submodules

```
git submodule sync
```

and we build the bindings
And we build the bindings

```
scons -j16 platform=linuxbsd target=debug

```

3 changes: 1 addition & 2 deletions src/Tensor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ Tensor::mapRawData()
this->mRawData = this->mDevice->mapMemory(
*hostVisibleMemory, 0, bufferSize, vk::MemoryMapFlags());

vk::MappedMemoryRange mappedMemoryRange(*hostVisibleMemory, 0, bufferSize);
}

void
Expand Down Expand Up @@ -241,7 +240,7 @@ Tensor::recordStagingBufferMemoryBarrier(const vk::CommandBuffer& commandBuffer,
vk::PipelineStageFlagBits srcStageMask,
vk::PipelineStageFlagBits dstStageMask)
{
KP_LOG_DEBUG("Kompute Tensor recording PRIMARY buffer memory barrier");
KP_LOG_DEBUG("Kompute Tensor recording STAGING buffer memory barrier");

this->recordBufferMemoryBarrier(commandBuffer,
*this->mStagingBuffer,
Expand Down
4 changes: 0 additions & 4 deletions src/include/kompute/Sequence.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -217,16 +217,12 @@ class Sequence : public std::enable_shared_from_this<Sequence>
/**
* Begins recording commands for commands to be submitted into the command
* buffer.
*
* @return Boolean stating whether execution was successful.
*/
void begin();

/**
* Ends the recording and stops recording commands when the record command
* is sent.
*
* @return Boolean stating whether execution was successful.
*/
void end();

Expand Down