Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to Vulkan 1.3 #302

Closed
wants to merge 14 commits into from
Closed

Upgraded to Vulkan 1.3 #302

wants to merge 14 commits into from

Conversation

MiroPalmu
Copy link
Contributor

@MiroPalmu MiroPalmu commented Sep 11, 2022

Upgraded to Vulkan 1.3 as default. Hopefully I have not missed anything nor broke anything. I'm not that familiar with Docker but seems like tests were at least working on my computer.

I have not done these even if I edited docs:

Updating documentation

To update the documentation you will need to:

Run the gendoxygen target in the build system
Run the gensphynx target in the build-system
Push to github pages with make push_docs_to_ghpages

Signed-off-by: Miro Palmu miro.palmu@helsinki.fi

Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
@MiroPalmu
Copy link
Contributor Author

MiroPalmu commented Sep 12, 2022

This PR does not use any 1.3 functionality but there was #265 on 1.0.0 project.

Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
…s recorded to sequence

Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
@MiroPalmu
Copy link
Contributor Author

Messed up with git and now PR #304 is in this. I can't figure out right now how to fix this. Also #304 includes this commits in this PR

@axsaucedo
Copy link
Member

Thank you for your contribution @MiroPalmu - it's very much appreciated.

There's quite a lot of changes in this PR that are not related to 1.3 upgrade, so the PR needs to be broken down and issues would have to be open to ensure these are addressed - I am quite keen to understand some of these proposed fixes and add them accordingly.

I have added a new PR #309 that focueses specifically on upgrading Vulkan SDK - it would be great if you could provide more details on the fixes that are included in this PR and we can look to add them in different PRs.

@axsaucedo axsaucedo closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants