Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding storage tensor functionality with tests #316

Merged
merged 5 commits into from
Dec 3, 2022

Conversation

axsaucedo
Copy link
Member

Addresses part of #14 as continuation from #304.

@MiroPalmu I have added this PR with a few fixes from the work you've done, really great push, the contribution is very much appreciated. This should now work as expected, two tests have been added - namely copying with the OpTensorCopy, and copying through an Algorithm.

Extra in this PR:

  • Ensuring SPDLOG is used by default in build config
  • Ensuring spdlog is set up as sync by default, but allow feature flag (otherwise debugging harder on segfault)

Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
@MiroPalmu
Copy link
Contributor

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants