Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the cmake script
cmake/check_vulkan_version.cmake
where it would not parse the output of
vulkaninfo
correctly.This results in the wrong header version being detected and therefore failing the driver check.
This PR fixes Issue #317
There are two bugs that have been addressed:
Even if the script detect a complete version in the vulkan header file (
VK_HEADER_VERSION_COMPLETE
) it fails to parse it, because the if statement is not evaluating the string value correctly.This has been fixed by checking with
STREQUAL
.When parsing the apiVersion itself the used regex used, expects some extra text and brackets, which are not present on all installations/drivers. Was there a change perhaps?
I checked this on 3 Machines with Ubuntu20, Ubuntu22 and Fedora38. With Vulkan 1.1.182, Vulkan 1.3.238 and Vulkan 1.3.243 installed respectively.
The version always looks like this:
apiVersion = 4206830 (1.3.238)
This has been fixed by relaxing the regex by adding
*
to these brackets and text matches.With these changes it parses the version correctly and should still parse these other formats as well.