Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler errors on compilers other than msvc #66

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Fix compiler errors on compilers other than msvc #66

merged 2 commits into from
Sep 27, 2020

Conversation

Dudecake
Copy link
Contributor

The removal of the references to temporary variables fixed the compilation of the array_multiplication example.

The removal of the default argument of kp::Manager::evalOp was necessary to use kp::Manager::evalOpDefault(std::vector<std::shared_ptr<Tensor>>, const char*)

@axsaucedo axsaucedo self-requested a review September 27, 2020 18:01
@axsaucedo axsaucedo added bug Something isn't working enhancement New feature or request labels Sep 27, 2020
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Dudecake ! Good catch on all these fixes!

@axsaucedo axsaucedo merged commit 5460681 into KomputeProject:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants