Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/pg update #572

Merged
merged 13 commits into from
Apr 6, 2022
Merged

Chore/pg update #572

merged 13 commits into from
Apr 6, 2022

Conversation

ubergesundheit
Copy link
Contributor

@ubergesundheit ubergesundheit commented Apr 4, 2022

This PR builds upon #541 with changes:

  • Rebased onto current main branch
  • Change the apiVersion in Chart.yaml to v2 as suggested by @edmund-wagner
  • Update to postgresql chart 11.1.15. It contains a fix in regards to RBAC resources
  • Update CI to use newer ct (3.5.1), helm (3.8.1) and python 3.9.7 versions
  • Update ct files to reflect changed values in postgresql chart
  • Add default value to use postgresql 13.6

What this PR does / why we need it:

The old postgresql subchart does not support RBAC.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • Commits follow the Kong commit message guidelines

rainest and others added 3 commits April 4, 2022 15:17
Upgrade to the latest Postgres sub-chart and improve documentation for
handling the Postgres password.
@ubergesundheit ubergesundheit requested a review from a team as a code owner April 4, 2022 13:33
@ubergesundheit
Copy link
Contributor Author

I'll change to a Draft PR for now, sorry for the noise

@ubergesundheit ubergesundheit marked this pull request as draft April 4, 2022 15:38
@ubergesundheit
Copy link
Contributor Author

Unsure what happened here, but latest error looks unrelated

@rainest @shaneutt

Error: module 'openssl.rand' not found:No LuaRocks module found for openssl.rand
	no field package.preload['openssl.rand']
	no file '/opt/openssl/rand.lua'
	no file '/opt/openssl/rand/init.lua'
	no file './openssl/rand.lua'
	no file './openssl/rand/init.lua'
	no file '/usr/local/openresty/site/lualib/openssl/rand.ljbc'
	no file '/usr/local/openresty/site/lualib/openssl/rand/init.ljbc'
	no file '/usr/local/openresty/lualib/openssl/rand.ljbc'
	no file '/usr/local/openresty/lualib/openssl/rand/init.ljbc'
	no file '/usr/local/openresty/site/lualib/openssl/rand.lua'
	no file '/usr/local/openresty/site/lualib/openssl/rand/init.lua'
	no file '/usr/local/openresty/lualib/openssl/rand.lua'
	no file '/usr/local/openresty/lualib/openssl/rand/init.lua'
	no file './openssl/rand.lua'
	no file '/usr/local/openresty/luajit/share/luajit-2.1.0-beta3/openssl/rand.lua'
	no file '/usr/local/share/lua/5.1/openssl/rand.lua'
	no file '/usr/local/share/lua/5.1/openssl/rand/init.lua'
	no file '/usr/local/openresty/luajit/share/lua/5.1/openssl/rand.lua'
	no file '/usr/local/openresty/luajit/share/lua/5.1/openssl/rand/init.lua'
	no file '/home/kong/.luarocks/share/lua/5.1/openssl/rand.lua'
	no file '/home/kong/.luarocks/share/lua/5.1/openssl/rand/init.lua'
	no file '/usr/local/openresty/site/lualib/openssl/rand.so'
	no file '/usr/local/openresty/lualib/openssl/rand.so'
	no file './openssl/rand.so'
	no file '/usr/local/lib/lua/5.1/openssl/rand.so'
	no file '/usr/local/openresty/luajit/lib/lua/5.1/openssl/rand.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
	no file '/home/kong/.luarocks/lib/lua/5.1/openssl/rand.so'
	no file '/usr/local/openresty/site/lualib/openssl.so'
	no file '/usr/local/openresty/lualib/openssl.so'
	no file './openssl.so'
	no file '/usr/local/lib/lua/5.1/openssl.so'
	no file '/usr/local/openresty/luajit/lib/lua/5.1/openssl.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
	no file '/home/kong/.luarocks/lib/lua/5.1/openssl.so'

@rainest
Copy link
Contributor

rainest commented Apr 4, 2022

The OpenSSL error is fixed by Kong/kong#8429, but I'm unsure of the release timeline for it; checking to see. If it's soon-ish, we should just wait for that to be out. If not, we'd need to pin the Postgres version to 13 for now.

Otherwise LGTM.

@ubergesundheit
Copy link
Contributor Author

Ah yes, have seen that before, now I remember. I was using enterprise kong-gateway container image where postgres 14 seems to work. Thanks for the suggestion :)

I think this is now ready for review

@ubergesundheit ubergesundheit marked this pull request as ready for review April 4, 2022 18:42
@rainest
Copy link
Contributor

rainest commented Apr 4, 2022

One last bit (also waiting on a response from the Gateway devs to see if we'd just be able to go to 14 in the near future): could you remove the tarball (both the original 8.x one and the new 11.x one) from charts/kong/charts entirely? There shouldn't actually be any reason for it to be there; it got checked in accidentally from someone's working copy that'd run helm dependency update while working directly from the repo.

@ubergesundheit
Copy link
Contributor Author

could you remove the tarball (both the original 8.x one and the new 11.x one) from charts/kong/charts entirely?

done in 0cbf680

@ubergesundheit
Copy link
Contributor Author

Mh looks like the archive is required ( see failed tests)

@ubergesundheit
Copy link
Contributor Author

maybe ec0a478 fixes the tests in CI

@rainest
Copy link
Contributor

rainest commented Apr 4, 2022

Gateway team have informed me that the 14 fix should be out imminently, so will wait a few days and then strip out the limit here barring some delay.

@ubergesundheit
Copy link
Contributor Author

Thanks! Can you give an estimate on how long we have to wait?

@rainest
Copy link
Contributor

rainest commented Apr 5, 2022

Should be within a week, or rather, if it's not, will merge this as-is.

@ubergesundheit
Copy link
Contributor Author

Thanks, looking forward 👍

@rainest
Copy link
Contributor

rainest commented Apr 6, 2022

Actually, whatever, we need to make other unrelated changes to bump the controller and chart version for the next release anyway, so will go ahead and merge this as-is and remove the image default then assuming the Kong release is ready.

@rainest rainest enabled auto-merge (squash) April 6, 2022 23:38
@rainest rainest merged commit 2e89647 into Kong:main Apr 6, 2022
@ubergesundheit
Copy link
Contributor Author

Thank you :)

@rainest
Copy link
Contributor

rainest commented Apr 7, 2022

Thank you for your contribution. Please fill out the following form to claim your contributor swag:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt.

@ubergesundheit
Copy link
Contributor Author

Nice, thank you :) Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants