-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests: Added e2e tests for gateway validation with konnect.
Also, this change adds a conditional that ensures that rbac flag used with konnect mode, gives an legible error to the user.
- Loading branch information
1 parent
e07f7b0
commit a05a422
Showing
4 changed files
with
123 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
_format_version: "3.0" | ||
_konnect: | ||
control_plane_name: default | ||
services: | ||
- connect_timeout: 60000 | ||
id: 58076db2-28b6-423b-ba39-a797193017f7 | ||
host: mockbin.org | ||
name: svc1 | ||
port: 80 | ||
protocol: http | ||
read_timeout: 60000 | ||
retries: 5 | ||
routes: | ||
- name: r1 | ||
id: 87b6a97e-f3f7-4c47-857a-7464cb9e202b | ||
https_redirect_status_code: 301 | ||
paths: | ||
- /r1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
//go:build integration | ||
|
||
package integration | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func Test_Validate_Konnect(t *testing.T) { | ||
setup(t) | ||
runWhen(t, "konnect", "") | ||
|
||
tests := []struct { | ||
name string | ||
stateFile string | ||
additionalArgs []string | ||
errorExpected bool | ||
}{ | ||
{ | ||
name: "validate with konnect", | ||
stateFile: "testdata/validate/konnect.yaml", | ||
additionalArgs: []string{}, | ||
}, | ||
{ | ||
name: "validate with --konnect-compatibility", | ||
stateFile: "testdata/validate/konnect.yaml", | ||
additionalArgs: []string{"--konnect-compatibility"}, | ||
}, | ||
{ | ||
name: "validate with --workspace", | ||
stateFile: "testdata/validate/konnect.yaml", | ||
additionalArgs: []string{"--workspace=default"}, | ||
}, | ||
} | ||
|
||
for _, tc := range tests { | ||
t.Run(tc.name, func(t *testing.T) { | ||
validateOpts := []string{ | ||
tc.stateFile, | ||
} | ||
validateOpts = append(validateOpts, tc.additionalArgs...) | ||
|
||
err := validate(true, validateOpts...) | ||
assert.NoError(t, err) | ||
}) | ||
} | ||
} | ||
|
||
func Test_Validate_Konnect_RBAC(t *testing.T) { | ||
setup(t) | ||
runWhen(t, "konnect", "") | ||
|
||
tests := []struct { | ||
name string | ||
stateFile string | ||
additionalArgs []string | ||
errorExpected bool | ||
}{ | ||
{ | ||
name: "validate with --rbac-resources-only", | ||
stateFile: "testdata/validate/rbac-resources.yaml", | ||
additionalArgs: []string{"--rbac-resources-only"}, | ||
}, | ||
} | ||
|
||
for _, tc := range tests { | ||
t.Run(tc.name, func(t *testing.T) { | ||
validateOpts := []string{ | ||
tc.stateFile, | ||
} | ||
validateOpts = append(validateOpts, tc.additionalArgs...) | ||
|
||
err := validate(true, validateOpts...) | ||
assert.Error(t, err) | ||
assert.Contains(t, err.Error(), "rbac validation not yet supported in konnect mode") | ||
}) | ||
} | ||
} | ||
|