Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix indentation in file-patch cli command #972

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jul 18, 2023

No description provided.

@Tieske Tieske added this to the 1.24.0 milestone Jul 18, 2023
@Tieske Tieske requested a review from a team July 18, 2023 11:42
@Tieske Tieske marked this pull request as draft July 18, 2023 11:45
@Tieske
Copy link
Member Author

Tieske commented Jul 18, 2023

@lena-larionova please have a look. All whitespace indentation was changed to tabs, which caused it to look really bad in the CLI (defaults to 8 spaces). Hence here I changed it to 1 tab, and everything beyond that to 2 space-indents.

Will this render properly in the docs? If not, how can we solve this such that it works for CLI and docs?

@@ -121,20 +121,20 @@ The plugin files have the following format (JSON or YAML) and are applied in the
order they are given:
{ "_format_version": "1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to ask earlier: any reason that this is format version 1.0? If no specific reason, then can we put 3.0, to match latest?

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested it on docs and it generates fine 👍

@Tieske Tieske marked this pull request as ready for review July 18, 2023 18:05
@Tieske Tieske merged commit 5d19fe6 into main Jul 18, 2023
@Tieske Tieske deleted the fix/patch branch July 18, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants