fix: add icon specific colors #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two24studios
requested review from
adamdehaven,
jillztom,
portikM and
ValeryG
as code owners
kongponents-bot
pushed a commit
that referenced
this pull request
May 10, 2024
## [1.12.12](v1.12.11...v1.12.12) (2024-05-10) ### Bug Fixes * add icon specific colors ([#287](#287)) ([63a4038](63a4038))
|
🎉 This PR is included in version 1.12.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The design team wanted to add some icon specific tokens to allow us to use slightly different colors from our base
color-texttokens. Icons don't require the same color contrast requirements as text does, so it makes sense to give more fine tune control over this.For context, icons only require 3:1 ratio to pass AA while text needs to be 4.5:1.
We followed the 'component-specific' approach here with name, thus why they are
icon-colorversuscolor-icon.