Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-entrypoint): clean-up dangling unix sockets #620

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

locao
Copy link
Contributor

@locao locao commented Jan 12, 2023

This change adds a clean-up step to remove all sockets that a previous Kong run may have left in $PREFIX directory.

Dangling unix sockets have been a pain point in recent Kong versions and was dealt in traditional Kong in Kong/kong#9254, but the kong script is not called when starting Kong inside a container, so a similar change to docker-entrypoint.sh was added here.

FTI-4525

docker-entrypoint.sh Outdated Show resolved Hide resolved
docker-entrypoint.sh Outdated Show resolved Hide resolved
@flrgh
Copy link
Contributor

flrgh commented Jan 12, 2023

There's a nearly identical entrypoint script at ubuntu/docker-entrypoint.sh. Do these changes need to be added there as well?

Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good to go! I requested a couple changes for bash quirks and some extra verbosity.

@Tieske
Copy link
Member

Tieske commented Jan 12, 2023

There's a nearly identical entrypoint script at ubuntu/docker-entrypoint.sh. Do these changes need to be added there as well?

Yes, they should.

@locao
Copy link
Contributor Author

locao commented Jan 16, 2023

There's a nearly identical entrypoint script at ubuntu/docker-entrypoint.sh. Do these changes need to be added there as well?

Good catch! Added the same set of changes to that file.

@locao locao requested a review from flrgh January 16, 2023 20:18
@locao locao merged commit d3411e0 into master Jan 17, 2023
@locao locao deleted the fix/cleanup_dangling_sockets branch January 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants