-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker-entrypoint): clean-up dangling unix sockets #620
Conversation
There's a nearly identical entrypoint script at ubuntu/docker-entrypoint.sh. Do these changes need to be added there as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good to go! I requested a couple changes for bash quirks and some extra verbosity.
Yes, they should. |
also be aware about files with spaces
Good catch! Added the same set of changes to that file. |
This change adds a clean-up step to remove all sockets that a previous Kong run may have left in $PREFIX directory.
Dangling unix sockets have been a pain point in recent Kong versions and was dealt in traditional Kong in Kong/kong#9254, but the
kong
script is not called when starting Kong inside a container, so a similar change todocker-entrypoint.sh
was added here.FTI-4525