Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KongClusterPlugin section should describe how to configure global plugin #2748

Closed
fffonion opened this issue Apr 7, 2021 · 1 comment
Closed

KongClusterPlugin section should describe how to configure global plugin #2748

fffonion opened this issue Apr 7, 2021 · 1 comment
Assignees
@lena-larionova

Comments

@fffonion
Copy link
Contributor

fffonion commented Apr 7, 2021

Currently, "Configure a global plugin" lives under "Using KongPlugin resource" section(https://docs.konghq.com/kubernetes-ingress-controller/1.2.x/guides/using-kongplugin-resource/#configure-a-global-plugin), but it's actually telling
about usage about KongClusterPlugin resource.
It can be moved to and "Using KongClusterPlugin resource" section,
and a link to the new place will appear in the old section.

From Kong/kong#6984
@lena-larionova
Copy link
Contributor

Looks like the "Using KongPlugin resource" section in https://docs.konghq.com/kubernetes-ingress-controller/1.2.x/guides/using-kongplugin-resource/#configure-a-global-plugin doesn't actually add any info that the specific KongClusterPlugin topic doesn't have. It does have better lead-in and descriptive text, so we can make use of that, but you're right - this doesn't belong here and is mostly confusing.

@lena-larionova lena-larionova self-assigned this Apr 8, 2021
anup-krai added a commit to anup-krai/docs.konghq.com that referenced this issue Sep 26, 2022
@anup-krai
Added an example for global plugin using KongClusterPlugin
51cb996 
Issue Reference - Kong#2748

There are examples present for creating KongClusterPlugin resource but there are no examples for creating global plugin using KongClusterPlugin resource which will run on each request.
@anup-krai anup-krai mentioned this issue Sep 26, 2022
Closed
anup-krai added a commit to anup-krai/docs.konghq.com that referenced this issue Sep 26, 2022
@anup-krai
Added an example for global plugin using KongClusterPlugin
edec20d 
Issue Reference - Kong#2748

There are examples present for creating KongClusterPlugin resource but there are no examples for creating global plugin using KongClusterPlugin resource which will run on each request.
@anup-krai anup-krai mentioned this issue Sep 26, 2022
Merged
cloudjumpercat added a commit that referenced this issue Sep 28, 2022
@anup-krai @cloudjumpercat
Added an example for global plugin using KongClusterPlugin (#4518)
87aedd6 
* Added an example for global plugin using KongClusterPlugin

Issue Reference - #2748

There are examples present for creating KongClusterPlugin resource but there are no examples for creating global plugin using KongClusterPlugin resource which will run on each request.

* Updated KongClusterPlugin reference

Updated KongClusterPlugin reference

* Apply suggestions from code review

* Update global plugin sections

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
rainest pushed a commit that referenced this issue Oct 3, 2022
@anup-krai @cloudjumpercat @rainest
Added an example for global plugin using KongClusterPlugin (#4518)
153eac9 
* Added an example for global plugin using KongClusterPlugin

Issue Reference - #2748

There are examples present for creating KongClusterPlugin resource but there are no examples for creating global plugin using KongClusterPlugin resource which will run on each request.

* Updated KongClusterPlugin reference

Updated KongClusterPlugin reference

* Apply suggestions from code review

* Update global plugin sections

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lena-larionova lena-larionova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fffonion @lena-larionova