-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy gateway documentation preview #3877
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for calling that out, because I meant to ask for feedback on exactly that 😄 I used the option you suggest for the dropdown, to show the two different approaches:
I agree with you that having the short list makes it more clear that this is an archive. The other thing I was thinking of is adding a banner across the whole site, calling out that this is an archive, to really drive the point home. |
Small copy suggestion on the banner Potential: or This documentation is no longer actively maintained. Go to the latest let me know what you think. |
That suggestion works. I actually haven't added a banner for the archive yet, that's one that exists on all of our versioned docs 😄 . For the archive banner, I want something more prominent/obvious than that one (visually, that is). |
3f8be3e
to
627b8c1
Compare
Once this is ready we should close the PR and create a branch preview on Netlify (like we did for Konnect) rather than using the PR preview. Is it just the main banner outstanding? |
b00a0cd
to
86a5b71
Compare
It's just the banner now, I'll do that today. Agree that we should close this PR then (especially since rebasing/merging to update this PR is extremely painful; any change to a "deleted" file causes a conflict, so it's not feasible to keep updating). I have a branch preview up at https://legacy-gateway--kongdocs.netlify.app now. |
Closing, this PR was only ever meant for generating a preview. |
DO NOT MERGE DO NOT MERGE DO NOT MERGE
This branch is for generating a Netlify preview only.
Because of this, please review the preview only and don't bother looking at the 3000+ changed files.
I've removed most of the doc content from this branch and left only the Gateway version that are already archived or will be with 3.0.
https://legacy-gateway--kongdocs.netlify.app/