Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin) merge statsd-advanced into statsd #4085

Merged
merged 18 commits into from
Jul 14, 2022
Merged

feat(plugin) merge statsd-advanced into statsd #4085

merged 18 commits into from
Jul 14, 2022

Conversation

vm-001
Copy link
Contributor

@vm-001 vm-001 commented Jul 4, 2022 •
edited
Loading

Summary

Merge features of statsd-advanced into statsd

Reason

https://konghq.atlassian.net/browse/FTI-4110

Testing

I have tested it in my local env.

FTI-4110

@vm-001 vm-001 requested a review from a team as a code owner July 4, 2022 03:38
@netlify
Copy link

netlify bot commented Jul 4, 2022 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 4fafac0
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/62d047c0076418000867760a
😎 Deploy Preview https://deploy-preview-4085--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vm-001 vm-001 added review:tech Request for technical review on the docs platform or processes. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:copyedit Request for writer review. labels Jul 4, 2022
@vm-001 vm-001 changed the title feat(plugin) merge statsd-advanced to statsd feat(plugin) merge statsd-advanced into statsd Jul 4, 2022
@cloudjumpercat cloudjumpercat self-requested a review July 5, 2022 13:53
@cloudjumpercat cloudjumpercat self-assigned this Jul 5, 2022
@lena-larionova
Copy link
Contributor

Two questions:

  • Which release of Kong Gateway is this change going into? Is it planned for 3.0?
  • Is statsd advanced being deprecated?

@cloudjumpercat cloudjumpercat removed their assignment Jul 5, 2022
@lena-larionova lena-larionova self-assigned this Jul 5, 2022
@vm-001
Copy link
Contributor Author

vm-001 commented Jul 6, 2022 •
edited
Loading

@lena-larionova

Which release of Kong Gateway is this change going into? Is it planned for 3.0?

Yes. It's planned for 3.0

Is statsd advanced being deprecated?

Yes. statsd-advanced will be deprecated.

And thanks for reminding me. I changed the base branch to release/3.0 and set the 3.0 milestone.

@vm-001 vm-001 changed the base branch from main to release/gateway-3.0 July 6, 2022 01:19
@vm-001 vm-001 added this to the Gateway 3.0 milestone Jul 6, 2022
lena-larionova
lena-larionova requested changes Jul 8, 2022
View reviewed changes
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
app/_hub/kong-inc/statsd/_index.md Outdated Show resolved Hide resolved
vm-001 and others added 12 commits July 11, 2022 08:52
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
b0c0309 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
e472119 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
e85afe9 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
88fd506 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
cd2ab58 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
f1e8c93 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
8f25a26 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
0ca8571 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
397a5d3 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
ecd36c3 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
710e9fb 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@vm-001 @lena-larionova
Update app/_hub/kong-inc/statsd/_index.md
c77fbde 
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@lena-larionova lena-larionova added blocked:kong Issues/PRs waiting on Kong PRs to merge before it can be solved labels Jul 13, 2022
@lena-larionova
Copy link
Contributor

@vm-001 I've turned this plugin doc into a single file - we're starting to do this with 3.0. I've tested it locally, it's building well, so the doc is ready to go.

lena-larionova
lena-larionova approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now.
Is it safe to merge? Merging in the interest of branch management - I need to do a huge rebase + update, and don't want to make more work for you. If this feature doesn't end up making it in, we can always revert.

@lena-larionova lena-larionova removed the blocked:kong Issues/PRs waiting on Kong PRs to merge before it can be solved label Jul 14, 2022
@lena-larionova lena-larionova merged commit 65d6202 into Kong:release/gateway-3.0 Jul 14, 2022
@vm-001
Copy link
Contributor Author

vm-001 commented Aug 4, 2022

Thank you. @lena-larionova

@lena-larionova lena-larionova mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

@cloudjumpercat cloudjumpercat Awaiting requested review from cloudjumpercat

Assignees

@lena-larionova lena-larionova

Labels
review:copyedit Request for writer review. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Milestone
Gateway 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vm-001 @lena-larionova @cloudjumpercat