Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FT-2788]fix opa documents undefined return #4211

Merged
merged 3 commits into from
Aug 9, 2022
Merged

[FT-2788]fix opa documents undefined return #4211

merged 3 commits into from
Aug 9, 2022

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Aug 9, 2022

Summary

  • Fix the example rego file in the OPA plugin documentation. Currently, the allowBoolean document does not have a default value, which means that if not evaluated the returned value will be undefined and the OPA decision response will be a {}, which will eventually cause a 500 error on Kong side. Can be reproduced by following the current version of document, https://docs.konghq.com/hub/kong-inc/opa/#usage. When trying request on the first time, the 500 error will occur.
  • Add two missing config params, include_body_in_opa_input and include_parsed_json_body_in_opa_input

Reason

Fix https://konghq.atlassian.net/browse/FT-2788

Testing

@windmgc windmgc added review:tech Request for technical review on the docs platform or processes. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Aug 9, 2022
@windmgc windmgc requested a review from a team as a code owner August 9, 2022 08:16
@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 2c8ee98
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/62f2623e4a0651000877369c
😎 Deploy Preview https://deploy-preview-4211--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Guaris Guaris self-assigned this Aug 9, 2022
@Guaris Guaris merged commit c9cdee8 into main Aug 9, 2022
@Guaris Guaris deleted the FT-2788 branch August 9, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants