Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datadog & statsd plugin missing doc #4979

Merged
merged 2 commits into from
Jan 5, 2023
Merged

add datadog & statsd plugin missing doc #4979

merged 2 commits into from
Jan 5, 2023

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Jan 3, 2023

Summary

This PR adds missing documentation on the new config fields for datadog & statsd plugins.
Ref: Kong/kong#9521

Reason

Testing

@windmgc windmgc added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jan 3, 2023
@windmgc windmgc requested a review from a team as a code owner January 3, 2023 08:51
@netlify
Copy link

netlify bot commented Jan 3, 2023 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 88d2f27
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/63b74f6ab17d6b00091d81d4
😎 Deploy Preview https://deploy-preview-4979--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lena-larionova lena-larionova self-assigned this Jan 4, 2023
lena-larionova
lena-larionova approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this info. I just added some changelog entries as well. LGTM!

@lena-larionova lena-larionova merged commit 913b86c into main Jan 5, 2023
@lena-larionova lena-larionova deleted the add-statsd-datadog-missing-doc branch January 5, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

Assignees

@lena-larionova lena-larionova

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@windmgc @lena-larionova