Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: latencies.kong description #7145

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Update: latencies.kong description #7145

merged 1 commit into from
Apr 4, 2024

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Mar 27, 2024 •
edited by jira bot
Loading

Description

We are no longer including receive time in latencies.kong. This updates the description accordingly.

I also put all of the >=3.7 changes into one conditional block. There is now some duplication, but I feel this makes things more readable to the human eye.

Testing instructions

Review the file-log plugin doc page.

Checklist

Links

KAG-3798

@flrgh flrgh added review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:copyedit Request for writer review. labels Mar 27, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit d24c531
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/660f123a8ff8320008464ca7
😎 Deploy Preview https://deploy-preview-7145--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 92 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@flrgh flrgh mentioned this pull request Mar 27, 2024
Merged
3 tasks
@flrgh
Copy link
Contributor Author

flrgh commented Mar 27, 2024 •
edited
Loading

Please hold for merge until after Kong/kong#12795 is merged.

Edit: merged!

nowNick
nowNick approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@nowNick nowNick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@flrgh flrgh marked this pull request as ready for review April 2, 2024 19:44
@flrgh flrgh requested a review from a team as a code owner April 2, 2024 19:44
@flrgh flrgh force-pushed the fix/file-log-latencies branch 2 times, most recently from a5570e9 to d6c6151 Compare April 2, 2024 19:46
@flrgh
Copy link
Contributor Author

flrgh commented Apr 4, 2024

hi @lena-larionova, mind taking another look at this?

@lena-larionova lena-larionova added this to the Gateway 3.7 milestone Apr 4, 2024
lena-larionova
lena-larionova approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, version conditionals are working now.

@lena-larionova lena-larionova merged commit c341c4f into main Apr 4, 2024
15 checks passed
@lena-larionova lena-larionova deleted the fix/file-log-latencies branch April 4, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

@nowNick nowNick nowNick approved these changes

Assignees
No one assigned
Labels
review:copyedit Request for writer review. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
Gateway 3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@flrgh @nowNick @lena-larionova