add tests

Kong · Sep 30, 2024 · 7fd4f21 · 7fd4f21
1 parent deb7f4c
commit 7fd4f21
Show file tree

Hide file tree

Showing 9 changed files with 706 additions and 11 deletions.
diff --git a/controller/konnect/ops/ops_kongsni.go b/controller/konnect/ops/ops_kongsni.go
@@ -35,7 +35,7 @@ func createSNI(
 	resp, err := sdk.CreateSniWithCertificate(ctx, sdkkonnectops.CreateSniWithCertificateRequest{
 		ControlPlaneID:    cpID,
 		CertificateID:     sni.Status.Konnect.CertificateID,
-		SNIWithoutParents: sdkkonnectcomp.SNIWithoutParents{},
+		SNIWithoutParents: kongSNIToSNIWithoutParents(sni),
 	})
 
 	if errWrapped := wrapErrIfKonnectOpFailed(err, CreateOp, sni); errWrapped != nil {

diff --git a/controller/konnect/reconciler_certificateref.go b/controller/konnect/reconciler_certificateref.go
@@ -70,7 +70,7 @@ func handleKongCertificateRef[T constraints.SupportedKonnectEntityType, TEnt con
 	// If referenced KongCertificate is being deleted, return an error so that we
 	// can remove the entity from Konnect first.
 	if delTimestamp := cert.GetDeletionTimestamp(); !delTimestamp.IsZero() {
-		return ctrl.Result{}, ReferencedKongUpstreamIsBeingDeleted{
+		return ctrl.Result{}, ReferencedKongCertificateIsBeingDeleted{
 			Reference:         nn,
 			DeletionTimestamp: delTimestamp.Time,
 		}