Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konnect entities: Key Set #585

Closed
3 tasks
Tracked by #370
randmonkey opened this issue Sep 12, 2024 · 0 comments · Fixed by #663
Closed
3 tasks
Tracked by #370

Konnect entities: Key Set #585

randmonkey opened this issue Sep 12, 2024 · 0 comments · Fixed by #663

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Sep 12, 2024

Problem statement

Introduce KongKeySet. As introduced here https://docs.konghq.com/gateway/latest/reference/key-management/, a Key requires a KeySet which it belongs to.

Proposed solution

  • Introduce KongKeySet CRD in https://github.com/Kong/kubernetes-configuration

    • All Kong configuration CRDs will live in that repository to prevent import cycles between KGO and KIC
    • This CRD will contain a ControlPlane reference. Only references that refer to Konnect will result in reconciliation against Konnect.
  • Implement a reconciler which will use that CRD.

  • This reconciler should be able to be disabled via CLI flag / env variable.

    • There should exist only 1 CLI flag / env variable for all Kong configuration entities like Consumers, Services, Routes etc.

Acceptance criteria

  • KGO can create, delete and update KeySets in Konnect based on the CRD spec.
  • Status fields of this CRD are filled with information such as
    • Indication whether the entity in Konnect has been created via a Programmed status condition
@randmonkey randmonkey added this to the KGO v1.4.x milestone Sep 12, 2024
@randmonkey randmonkey changed the title Gateway - Key Set Konnect Entity: Key Set Sep 12, 2024
@pmalek pmalek changed the title Konnect Entity: Key Set Konnect entities: Key Set Sep 13, 2024
@czeslavo czeslavo self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants