Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(konnect): add KongKey - KongKeySet binding #663

Merged
merged 5 commits into from
Oct 2, 2024
Merged

feat(konnect): add KongKey - KongKeySet binding #663

merged 5 commits into from
Oct 2, 2024

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Implements the KongKey - KongKeySet binding by handling the KeySetRef in the KongKey.

Which issue this PR fixes

Fixes #585.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@czeslavo czeslavo added this to the KGO v1.4.x milestone Sep 27, 2024
@czeslavo czeslavo marked this pull request as ready for review September 27, 2024 11:53
@czeslavo czeslavo requested a review from a team as a code owner September 27, 2024 11:53
pmalek
pmalek reviewed Sep 27, 2024
View reviewed changes
controller/konnect/ops/ops_kongkey_test.go Show resolved Hide resolved
controller/konnect/reconciler_generic.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_generic.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_generic.go Outdated Show resolved Hide resolved
@czeslavo czeslavo mentioned this pull request Oct 1, 2024
Merged
@czeslavo czeslavo requested a review from pmalek October 2, 2024 13:18
pmalek
pmalek reviewed Oct 2, 2024
View reviewed changes
controller/konnect/watch_kongkey.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_keysetref.go Show resolved Hide resolved
controller/konnect/reconciler_keysetref.go Outdated Show resolved Hide resolved
@pmalek pmalek mentioned this pull request Oct 2, 2024
Open
1 task
@czeslavo czeslavo requested a review from pmalek October 2, 2024 14:56
@czeslavo czeslavo enabled auto-merge (squash) October 2, 2024 15:01
@czeslavo czeslavo merged commit 3fd897a into main Oct 2, 2024
21 checks passed
@czeslavo czeslavo deleted the feat/key-keyset-binding branch October 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees
No one assigned
Labels
area/konnect
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.

Konnect entities: Key Set
2 participants
@czeslavo @pmalek